Fields

hardware None
os None

Parameters

Fields

NameValue

Parameters

NameValue
git_commit commit bba4ded3c2f94fe0de6011a6941b135b3cb0370a
Author: A. Jiang <de34@live.cn>
Date: Thu Jun 12 22:53:41 2025 +0800

[libc++] Fix constructing `bitset` from non-null-terminated arrays (#143691)

Unconditional evaluation of `char_traits<_CharT>::length(__str)` is problematic, because it causes
UB when `__str` points to a non-null-terminated array. We should only call `length` (currently, in
`basic_string_view`'s constructor) when `__n == npos` per [bitset.cons]/8.

Drive-by change: Reduction of conditional compilation, given that
- both `basic_string_view<_CharT>::size_type` and `basic_string<_CharT>::size_type` must be
`size_t`, and thus
- both `basic_string_view<_CharT>::npos` and `basic_string<_CharT>::npos` must be `size_t(-1)`.

For the type sameness in the standard wording, see:
- [string.view.template.general]
- [basic.string.general]
- [allocator.traits.types]/6
- [default.allocator.general]/1

Fixes #143684
Filter

ldionne-old-macbook-results test results

Run Order Start Time Duration
Current 540766 2025-12-16T16:40:01 0:00:00
Previous 541098 2025-12-16T16:40:01 0:00:00
Baseline 485288 2025-12-16T16:40:01 0:00:00


Tests Summary

Status Group # # (B)
Performance Improvements 6 0
Added Tests 0 18
Unchanged Tests 84 72
Total Tests 90

Performance Improvements - execution_time Δ Previous Current σ Δ (B) σ (B)
737_gmsh_r -2.78% 13.489 13.115 - 0.00% -
727_cppcheck_r -1.50% 25.049 24.673 - 0.00% -
707_ntest_r -1.43% 18.327 18.065 - 0.00% -
753_ns3_r -1.34% 10.848 10.703 - 0.00% -
734_vpr_r -1.26% 15.580 15.383 - 0.00% -
706_stockfish_r -1.25% 22.586 22.304 - 0.00% -

Added Tests - execution_time
706_stockfish_r
707_ntest_r
709_cactus_r
710_omnetpp_r
721_gcc_r
723_llvm_r
727_cppcheck_r
729_abc_r
731_astcenc_r
734_vpr_r
735_gem5_r
736_ocio_r
737_gmsh_r
748_flightdm_r
750_sealcrypto_r
753_ns3_r
766_femflow_r
767_nest_r


Report Time: 0.09s
Name Current %
706_stockfish_r 22.304 -1.25%
707_ntest_r 18.065 -1.43%
709_cactus_r 19.736 -
710_omnetpp_r 8.466 -
721_gcc_r 12.998 -
723_llvm_r 11.619 -
727_cppcheck_r 24.673 -1.50%
729_abc_r 18.747 -
731_astcenc_r 10.144 -
734_vpr_r 15.383 -1.26%
735_gem5_r 14.057 -
736_ocio_r 16.270 -
737_gmsh_r 13.115 -2.78%
748_flightdm_r 8.925 -
750_sealcrypto_r 18.489 -
753_ns3_r 10.703 -1.34%
766_femflow_r 12.863 -
767_nest_r 14.357 -
Geometric Mean 14.410 -